-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tlsmin connection parameter #45
Conversation
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 72.03% 72.14% +0.10%
==========================================
Files 23 23
Lines 5604 5604
==========================================
+ Hits 4037 4043 +6
+ Misses 1319 1314 -5
+ Partials 248 247 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
I am just adding this comment here Just change the code at the beginning in SetupTLS to config := tls.Config{
} |
I don't think the goal is to make 1.0 the default all the time, as it's not secure. |
Fixes #33
Adds
tlsmin
parameter to the connection string to enable use of 1.0 and 1.1 as needed.