Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial logic check for merging 2 entities #1092

Merged
merged 6 commits into from
Jul 9, 2023

Conversation

gokullan
Copy link
Contributor

@gokullan gokullan commented Jun 15, 2023

Change Description

This makes modifications to the anonymizer_engine.py file to add functionality to merge entities separated by a whitespace. This current commit does not implement some of the items in the checklist - I will make the next required commits that address these at the earliest.

Issue reference

This PR fixes issue #1090

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@gokullan
Copy link
Contributor Author

@microsoft-github-policy-service agree

@gokullan
Copy link
Contributor Author

I have added a test-case. Do let me know if that is the expected behaviour or if any changes are needed.

@omri374
Copy link
Contributor

omri374 commented Jun 17, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Jun 17, 2023

Thanks @gokullan! We will review this PR in the next few days.

Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gokullan! I've added a few minor suggestions, but this looks great.

@gokullan
Copy link
Contributor Author

Sure, will make the requested changes.

@omri374
Copy link
Contributor

omri374 commented Jun 19, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 requested review from SharonHart and navalev June 19, 2023 15:22
@omri374
Copy link
Contributor

omri374 commented Jul 2, 2023

waiting for a second approval to approve @navalev @SharonHart @shiranr

@omri374
Copy link
Contributor

omri374 commented Jul 9, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit d51ff56 into microsoft:main Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants