-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial logic check for merging 2 entities #1092
Conversation
@microsoft-github-policy-service agree |
I have added a test-case. Do let me know if that is the expected behaviour or if any changes are needed. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks @gokullan! We will review this PR in the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @gokullan! I've added a few minor suggestions, but this looks great.
Sure, will make the requested changes. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
waiting for a second approval to approve @navalev @SharonHart @shiranr |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Change Description
This makes modifications to the
anonymizer_engine.py
file to add functionality to merge entities separated by a whitespace. This current commit does not implement some of the items in the checklist - I will make the next required commits that address these at the earliest.Issue reference
This PR fixes issue #1090
Checklist