New Predefined Recognizer: IN_PAN #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added India PAN (Permanent Account Number) recognizer
refined the regex for better recognition and enhanced the test cases accordingly
|
@microsoft-github-policy-service agree [company="{BlackhawkNetwork}"] |
|
@microsoft-github-policy-service agree company="Blackhawk Network" |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@devopam please run |
Fixed lint error that was missed earlier.
|
that was a bad miss. fixed and ran lint - no errors reported on local. Also, black recommended no changes |
Added test cases , verification and context data
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
omri374
reviewed
Jul 2, 2023
Added negative test cases per review comments.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SharonHart
reviewed
Jul 9, 2023
presidio-analyzer/presidio_analyzer/predefined_recognizers/in_pan_recognizer.py
Show resolved
Hide resolved
SharonHart
approved these changes
Jul 9, 2023
|
@devopam would you be interested in adding the checksum logic in a new PR? |
|
/azp run |
|
No commit pushedDate could be found for PR 1100 in repo microsoft/presidio |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Mergine this one, the checksum capability would be added in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added presidio predefined recognizer : IN_PAN
Describe your changes
Added pattern and context based recognizer InPanRecognizer to predefined recognizers.
This recognizer is for India Permanent Account Number (PAN) which is the primary unique taxpayer identifier for all citizens.
Issue reference
This PR fixes issue #XX
Checklist