Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base64 encoded key #1132

Closed
wants to merge 3 commits into from
Closed

Conversation

zizhong
Copy link

@zizhong zizhong commented Jul 28, 2023

Change Description

This PR enables that the encrypt operator and decrypt operator to use base64 encoded keys.

Issue reference

This PR fixes issue #1131

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@zizhong
Copy link
Author

zizhong commented Jul 28, 2023

@microsoft-github-policy-service agree company="Opaque"

@omri374
Copy link
Contributor

omri374 commented Aug 21, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Aug 21, 2023

Thank you @zizhong! Apologies for the delay in responding. We will review this shortly

@SharonHart
Copy link
Contributor

@zizhong I haven't seen this PR and already implemented an alternative, what is your take on both?
#1147
I think that yours is also covering the REST API, but also a breaking change?

@zizhong
Copy link
Author

zizhong commented Aug 21, 2023

@SharonHart Thanks! I think your solution is cleaner for python APIs. Besides, I have limited cycle working on this so would be great to push your PR and I can close this one.

@zizhong
Copy link
Author

zizhong commented Aug 21, 2023

@omri374 No worries! Since @SharonHart implemented an alternative, I think we can close this one to avoid duplication of efforts.

@zizhong
Copy link
Author

zizhong commented Aug 21, 2023

Closing this in favor of #1147

@zizhong zizhong closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants