Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifying exception test error type #1148

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Specifying exception test error type #1148

merged 2 commits into from
Aug 23, 2023

Conversation

niwilso
Copy link
Collaborator

@niwilso niwilso commented Aug 21, 2023

Change Description

Minor change to the exception test for DicomImageRedactorEngine._get_analyzer_results() such that we look for a TypeError exception specifically rather than any exception type.

Issue reference

This PR fixes issue #XX

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@niwilso niwilso marked this pull request as ready for review August 21, 2023 14:33
@omri374 omri374 merged commit 994074b into main Aug 23, 2023
@SharonHart SharonHart deleted the niwilso/dicom/test-exception-type branch August 23, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omri374 omri374 omri374 approved these changes

@SharonHart SharonHart SharonHart approved these changes

@ayabel ayabel Awaiting requested review from ayabel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niwilso @omri374 @SharonHart