Enable regex flags manipulation #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # mkdocs.yml # presidio-analyzer/Pipfile # presidio-analyzer/conf/default.yaml # presidio-analyzer/conf/spacy.yaml # presidio-analyzer/conf/spacy_multilingual.yaml # presidio-analyzer/conf/stanza.yaml # presidio-analyzer/conf/stanza_multilingual.yaml # presidio-analyzer/conf/transformers.yaml # presidio-analyzer/tests/conf/default.yaml # presidio-analyzer/tests/test_stanza_recognizer.py
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SharonHart
previously approved these changes
Oct 25, 2023
navalev
previously approved these changes
Oct 25, 2023
SharonHart
previously approved these changes
Oct 25, 2023
SharonHart
approved these changes
Oct 26, 2023
navalev
approved these changes
Oct 26, 2023
| @@ -37,9 +39,9 @@ def __init__( | |||
| deny_list: List[str] = None, | |||
| context: List[str] = None, | |||
| deny_list_score: float = 1.0, | |||
| global_regex_flags: Optional[int] = re.DOTALL | re.MULTILINE | re.IGNORECASE, | |||
There was a problem hiding this comment.
This is pretty bad. You just change the default value from re.DOTALL | re.MULTILINE to re.DOTALL | re.MULTILINE | re.IGNORECASE.
This affect us as a client of this library.
There was a problem hiding this comment.
@ducquangkstn thanks for the feedback. This change allows you to have more customizability with regards to regex flags. Is this blocking you in any way?
There was a problem hiding this comment.
Is this blocking you in any way?
Actually, no. It just took me a while to figure out why the behavior is changed when pumping presidio version.
We (my company) are lucky that we have some unit tests. Not sure about other ppl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
As a user I would like to customize the regex flags used by Presidio, to be able to pass flags not defined initially.
Regex flags can be set on the
PatternRecognizer's constructor, or in theRecognizerRegistryconstructor to support all existingPatternRecognizers:Issue reference
This PR fixes issue #1029
Checklist