Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update anonymize_list type hints and document that sometimes items will be ignored. #1252

Merged

Conversation

JosephSBoyle
Copy link
Contributor

@JosephSBoyle JosephSBoyle commented Jan 8, 2024

Replace object with Any. Mark the input list argument as being nullable. Document the existing behaviour in the docstring.

Issue reference

This PR fixes issue #1249

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • N/A My code includes unit tests
  • N/A All unit tests and lint checks pass locally
  • N/A My PR contains documentation updates / additions if required

Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omri374
Copy link
Contributor

omri374 commented Jan 8, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit ca7772c into microsoft:main Jan 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants