predefined pattern recognizer : IN_VEHICLE_REGISTRATION #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added India PAN (Permanent Account Number) recognizer
refined the regex for better recognition and enhanced the test cases accordingly
Fixed lint error that was missed earlier.
Added test cases , verification and context data
Added negative test cases per review comments.
linted code
update pattern recognizer value per suggestion in review
added PresidioAnalyzerUtils class with generic functions. removed usage of stdnum
added test cases for analyzer_utils.py in prescribed format
added to the count of predefined recognizers
Added India specific predefined pattern recognizer for vehicle registration number
|
Hi @omri374 , please have a look when feasible and let me know your review comments |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks! I'll review it soon. |
omri374
reviewed
Feb 10, 2024
...idio-analyzer/presidio_analyzer/predefined_recognizers/in_vehicle_registration_recognizer.py
Outdated
Show resolved
Hide resolved
omri374
reviewed
Feb 10, 2024
...idio-analyzer/presidio_analyzer/predefined_recognizers/in_vehicle_registration_recognizer.py
Outdated
Show resolved
Hide resolved
omri374
reviewed
Feb 10, 2024
reinstated python 3.9 compatibility, reorganized code
|
Hi @omri374 , |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
omri374
reviewed
Feb 15, 2024
...idio-analyzer/presidio_analyzer/predefined_recognizers/in_vehicle_registration_recognizer.py
Outdated
Show resolved
Hide resolved
...idio-analyzer/presidio_analyzer/predefined_recognizers/in_vehicle_registration_recognizer.py
Outdated
Show resolved
Hide resolved
...idio-analyzer/presidio_analyzer/predefined_recognizers/in_vehicle_registration_recognizer.py
Outdated
Show resolved
Hide resolved
Logic reverted from analyzer_utils to recognizer classfile
added min size check to avoid failures per review comment
|
hi @omri374 , |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
omri374
reviewed
Feb 18, 2024
...idio-analyzer/presidio_analyzer/predefined_recognizers/in_vehicle_registration_recognizer.py
Outdated
Show resolved
Hide resolved
...idio-analyzer/presidio_analyzer/predefined_recognizers/in_vehicle_registration_recognizer.py
Outdated
Show resolved
Hide resolved
...idio-analyzer/presidio_analyzer/predefined_recognizers/in_vehicle_registration_recognizer.py
Show resolved
Hide resolved
...idio-analyzer/presidio_analyzer/predefined_recognizers/in_vehicle_registration_recognizer.py
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
omri374
approved these changes
Feb 20, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Addition of a predefined recognizer : IN_VEHICLE_REGISTRATION
Describe your changes
Pattern, Context and Checksum based recognizer for India RTO issued vehicle registration number
Issue reference
This PR fixes issue #XX
Checklist