feat: Add Bech32 and Bech32m Bitcoin Address Validation in Crypto Recognizer and expand tests #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated SG_NRIC_FIN Recognizer to include 'M' prefix for validating NRIC numbers issued to foreigners from 2022 onwards. - Added new test cases to ensure comprehensive coverage and validation accuracy for all supported NRIC prefixes (S, T, F, G, M).
- Introduced a new test case to validate the recognition of valid NRIC/FIN numbers when embedded within a sentence
- Extended the CryptoRecognizer with the capability to validate Bech32 and Bech32m Bitcoin addresses - Added new test cases have been added to cover Bech32 and Bech32m address validation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
omri374
approved these changes
Feb 20, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks! |
|
@omri374 thanks for merging my PR! I'm considering whether there might be interest in expanding the CryptoRecognizer to support addresses from cryptocurrencies other than Bitcoin. Would this be a valuable addition? |
|
Absolutely |
|
Cool! I'll look into it soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Issue reference
This PR fixes issue #1306
Checklist