Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Singapore UEN Recognizer #1315

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

miltonsim
Copy link
Contributor

Change Description

  • Added SingaporeUENRecognizer class to the recognizers module.
  • Implemented logic for detecting and validating various UEN formats.
  • Added unit tests covering different UEN formats and scenarios

Issue reference

This PR fixes issue #1314

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

miltonsim and others added 8 commits February 17, 2024 09:53
- Updated SG_NRIC_FIN Recognizer to include 'M' prefix for validating NRIC numbers issued to foreigners from 2022 onwards.
- Added new test cases to ensure comprehensive coverage and validation accuracy for all supported NRIC prefixes (S, T, F, G, M).
- Introduced a new test case to validate the recognition of valid NRIC/FIN numbers when embedded within a sentence
- Extended the CryptoRecognizer with the capability to validate Bech32 and Bech32m Bitcoin addresses
- Added new test cases have been added to cover Bech32 and Bech32m address validation
@omri374
Copy link
Contributor

omri374 commented Feb 28, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@omri374 omri374 merged commit d71c5fb into microsoft:main Feb 28, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants