Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Span Marker Recognizer Sample #1321

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

VMD7
Copy link
Contributor

@VMD7 VMD7 commented Mar 3, 2024

Adding Span Marker Recognizer Sample

Change Description

-> Following the approach of Flair Recognizer, a sample integration of Span Marker Recognizer has been incorporated into Presidio.

Issue reference

This PR fixes issue #1237

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

omri374
omri374 previously approved these changes Mar 12, 2024
Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! added two minor comments

Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@omri374
Copy link
Contributor

omri374 commented Mar 12, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit 733cca2 into microsoft:main Mar 13, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants