-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new recognizer for IN_VOTER #1344 #1345
Conversation
@microsoft-github-policy-service agree |
presidio-analyzer/presidio_analyzer/predefined_recognizers/in_voter_recognizer.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/predefined_recognizers/in_voter_recognizer.py
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
presidio-analyzer/presidio_analyzer/predefined_recognizers/in_voter_recognizer.py
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved considering Omri's comment on reducing the base score
@omri374 thank you for your time to reviewing this, i have updated the changes accordingly as per your suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@kjdeveloper8 the CI is failing due to a test counting the number of predefined recognizers. Can you please update it? |
updated |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks! Merged |
Change Description
Issue reference
This PR fixes issue #1344
Checklist