Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new recognizer for IN_VOTER #1344 #1345

Merged
merged 13 commits into from
Apr 16, 2024
Merged

feat: Add new recognizer for IN_VOTER #1344 #1345

merged 13 commits into from
Apr 16, 2024

Conversation

kjdeveloper8
Copy link
Contributor

Change Description

  • Add new reconizer IN_VOTER with regex
  • Added test module for the same

Issue reference

This PR fixes issue #1344

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests and linting
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@kjdeveloper8
Copy link
Contributor Author

@microsoft-github-policy-service agree

@omri374
Copy link
Contributor

omri374 commented Mar 28, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Mar 30, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Mar 30, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SharonHart
SharonHart previously approved these changes Mar 31, 2024
Copy link
Contributor

@SharonHart SharonHart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved considering Omri's comment on reducing the base score

@kjdeveloper8
Copy link
Contributor Author

@omri374 thank you for your time to reviewing this, i have updated the changes accordingly as per your suggestions

omri374
omri374 previously approved these changes Apr 1, 2024
Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omri374
Copy link
Contributor

omri374 commented Apr 1, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SharonHart
SharonHart previously approved these changes Apr 2, 2024
Copy link
Contributor

@SharonHart SharonHart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@omri374 omri374 dismissed stale reviews from SharonHart and themself via c41a93a April 11, 2024 19:12
@omri374
Copy link
Contributor

omri374 commented Apr 11, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Apr 11, 2024

@kjdeveloper8 the CI is failing due to a test counting the number of predefined recognizers. Can you please update it?

@kjdeveloper8
Copy link
Contributor Author

updated

@omri374
Copy link
Contributor

omri374 commented Apr 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Apr 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit 41e0202 into microsoft:main Apr 16, 2024
30 checks passed
@omri374
Copy link
Contributor

omri374 commented Apr 16, 2024

Thanks! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants