Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Predefined Recognizer for Indian Passport #1350 #1351

Merged
merged 20 commits into from
Apr 15, 2024

Conversation

Hiten-98
Copy link
Contributor

@Hiten-98 Hiten-98 commented Apr 2, 2024

Change Description

Describe your changes
This predefined recognizer will help in protecting PII element which is Indian Passport Number.
Predefined Recognizer named IN_PASSPORT is added

Issue reference

This PR fixes issue #1350

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@Hiten-98
Copy link
Contributor Author

Hiten-98 commented Apr 2, 2024

@microsoft-github-policy-service agree

@omri374
Copy link
Contributor

omri374 commented Apr 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

omri374
omri374 previously approved these changes Apr 11, 2024
Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@omri374 omri374 self-requested a review April 11, 2024 20:01
omri374
omri374 previously approved these changes Apr 12, 2024
@omri374
Copy link
Contributor

omri374 commented Apr 12, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Hiten-98
Copy link
Contributor Author

Hiten-98 commented Apr 12, 2024

Hi @omri374, I saw few checks were not successful, after analyzing I found those were linting issues and I have fixed those. There are no errors in local after running flake8. I have updated the code.

Thank you

@omri374
Copy link
Contributor

omri374 commented Apr 14, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit 5ea004d into microsoft:main Apr 15, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants