Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Docker ports with documentation and postman collection. #1375

Merged
merged 1 commit into from
May 8, 2024

Conversation

ungana
Copy link
Contributor

@ungana ungana commented May 7, 2024

The ports on the samples on this page (https://microsoft.github.io/presidio/samples/docker/) and the postman collection do not align with the documentation found here. This PR is to align it.

Change Description

Updated port references to match documentation and postman collections.

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

The ports on the samples on this page (https://microsoft.github.io/presidio/samples/docker/) and the postman collection do not align with the documentation found here.
Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omri374 omri374 merged commit ff31243 into microsoft:main May 8, 2024
3 checks passed
@ungana
Copy link
Contributor Author

ungana commented May 8, 2024

Thanks!

No problem. Thanks for putting this software out there for all to use. 🙏

@SharonHart SharonHart mentioned this pull request Jul 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants