Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix N818, E721 #1382

Merged
merged 9 commits into from
May 12, 2024
Merged

Fix N818, E721 #1382

merged 9 commits into from
May 12, 2024

Conversation

SharonHart
Copy link
Contributor

@SharonHart SharonHart commented May 12, 2024 •
edited
Loading

Change Description

Fix N818, renaming InvalidParamException to InvalidParamError
Fix E721, using isinstance instead of type

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@SharonHart SharonHart requested a review from omri374 May 12, 2024 07:54
omri374
omri374 previously approved these changes May 12, 2024
View reviewed changes
Base automatically changed from shhart/bugfix/autoformats-and-docstrings to main May 12, 2024 10:12
@SharonHart SharonHart dismissed omri374’s stale review May 12, 2024 10:12

The base branch was changed.

@SharonHart SharonHart force-pushed the shhart/bugfix/fix-n818-e721 branch from 7fc2b5c to e41cfd1 Compare May 12, 2024 10:16
@SharonHart SharonHart merged commit 2d92539 into main May 12, 2024
32 checks passed
@SharonHart SharonHart deleted the shhart/bugfix/fix-n818-e721 branch May 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omri374 omri374 omri374 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SharonHart @omri374