Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Python Packaging to pyproject.toml #1383

Merged
merged 6 commits into from
May 19, 2024
Merged

Migrate Python Packaging to pyproject.toml #1383

merged 6 commits into from
May 19, 2024

Conversation

SharonHart
Copy link
Contributor

@SharonHart SharonHart commented May 12, 2024 •
edited
Loading

Change Description

Modernize packaging by migrating from setup.py to pyproject.toml:

  • Dropped all setup.py and setup.cfg
  • Added pyproject.toml for all 5 presidio packages
  • Used 'flat-layout' automatic package discovery, dropping all tool.setuptools and tool.setuptools.packages.find options
  • Read versions from VERSION file, add one where missing
  • Used bdist wheel pakaging, updated release pipeline accordingly.

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@SharonHart SharonHart requested a review from a team as a code owner May 12, 2024 12:07
@omri374
Copy link
Contributor

omri374 commented May 12, 2024

Looks great. Can you please add the changes to deployment scripts into this PR? or should it come in a subsequent PR?

@SharonHart SharonHart requested review from omri374 and navalev May 15, 2024 08:03
@navalev
Copy link
Contributor

navalev commented May 15, 2024

LGTM. Any documentation that needs to change as well?

navalev
navalev previously approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@navalev navalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally

omri374
omri374 previously approved these changes May 17, 2024
View reviewed changes
@SharonHart SharonHart dismissed stale reviews from omri374 and navalev via 488ec49 May 19, 2024 05:01
@SharonHart SharonHart merged commit e65c89c into main May 19, 2024
32 checks passed
@SharonHart SharonHart deleted the shhart/feature/modern-packaging branch May 19, 2024 05:16
areyesfalcon added a commit to areyesfalcon/presidio that referenced this pull request May 20, 2024
@areyesfalcon
Merge pull request #8 from microsoft/main
e492d75 
Migrate Python Packaging to pyproject.toml (microsoft#1383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omri374 omri374 omri374 left review comments

@roeybc roeybc roeybc left review comments

@navalev navalev navalev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SharonHart @omri374 @navalev @roeybc