Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/analyzer documentation #1384

Merged
merged 14 commits into from
May 30, 2024
Merged

Feature/analyzer documentation #1384

merged 14 commits into from
May 30, 2024

Conversation

roeybc
Copy link
Contributor

@roeybc roeybc commented May 14, 2024

Change Description

Add docs for analyzer_engine_provider & recognizer_registry_provider

Issue reference

This PR fixes issue #XX

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

omri374
omri374 reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is great. I left a few suggestions and small fixes.

I think it's worth going over the documentation and thinking of places where linking to this section makes sense. One of them could be the tutorial, where next to code-first configuration, we can suggest this approach. Another could be the customization jupyter notebook.

omri374
omri374 approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work :)

@omri374 omri374 merged commit 67d5837 into main May 30, 2024
32 checks passed
@omri374 omri374 deleted the feature/analyzer_documentation branch May 30, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omri374 omri374 omri374 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roeybc @omri374