Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that configuration files are closed when loading them #1423

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

saulbein
Copy link
Contributor

@saulbein saulbein commented Jul 24, 2024

Change Description

When configuration is loaded, the current version of the code only does an open call which leaves a dangling file reference that is never closed. While this isn't a major issue, we found that in the project where we use presidio, this causes pytest to issue warnings about unclosed resources (that for us is set up to be converted into test errors).

I'm not sure why, but this happens only with version 2.2.354 but not 2.2.353.

Issue reference

Didn't create an issue as just contributing a fix was faster for me.

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally

@omri374
Copy link
Contributor

omri374 commented Jul 24, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit 8dc46e2 into microsoft:main Jul 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants