Make sure that configuration files are closed when loading them #1423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When configuration is loaded, the current version of the code only does an
open
call which leaves a dangling file reference that is never closed. While this isn't a major issue, we found that in the project where we use presidio, this causes pytest to issue warnings about unclosed resources (that for us is set up to be converted into test errors).I'm not sure why, but this happens only with version
2.2.354
but not2.2.353
.Issue reference
Didn't create an issue as just contributing a fix was faster for me.
Checklist