-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory usage of Analyzer test suite #1429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
Thanks! |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
omri374
reviewed
Aug 5, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
omri374
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Reduce memory usage of Presidio Analyzer test suite (excluding Azure AI language recognizer tests) down to ~6GB from ~8GB. When run locally the tests runtime went from ~60 seconds to ~25 seconds.
Memray memory usgae graphs
Before
After
Changes
nlp.load
call on each iteration of Stanza and transformers recognizer tests.test_when_analyze_with_unsupported_language_must_match
tests to avoid callingAnalyzerEngine
five times in single testtest_when_analyze_with_unsupported_language_must_match
as test doesn't require nlp model to be loadedIssue reference
This PR fixes issue #1427
Checklist