Dev containers for: analyzer, analyzer+transformers, anonymizer and image redaction #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeybc
commented
Sep 9, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SharonHart
reviewed
Sep 10, 2024
roeybc
commented
Sep 10, 2024
SharonHart
previously approved these changes
Sep 10, 2024
Comment on lines
+1
to
+20
| FROM python:3.9-slim | ||
|
|
||
| ARG DEV_MODE=dev | ||
| ARG POETRY_EXTRAS="" | ||
| ARG NLP_CONF_FILE=presidio_analyzer/conf/default.yaml | ||
| ARG ANALYZER_CONF_FILE=presidio_analyzer/conf/default_analyzer.yaml | ||
| ARG RECOGNIZER_REGISTRY_CONF_FILE=presidio_analyzer/conf/default_recognizers.yaml | ||
|
|
||
| ENV DEV_MODE=${DEV_MODE} | ||
| ENV PIP_NO_CACHE_DIR=1 | ||
| ENV ANALYZER_CONF_FILE=${ANALYZER_CONF_FILE} | ||
| ENV RECOGNIZER_REGISTRY_CONF_FILE=${RECOGNIZER_REGISTRY_CONF_FILE} | ||
| ENV NLP_CONF_FILE=${NLP_CONF_FILE} | ||
| ENV POETRY_EXTRAS=${POETRY_EXTRAS} | ||
|
|
||
| # Install essential build tools | ||
| RUN apt-get update \ | ||
| && apt-get install -y build-essential | ||
|
|
||
| RUN pip install poetry |
Check notice
Code scanning / checkov
Ensure that HEALTHCHECK instructions have been added to container images Note
Comment on lines
+1
to
+20
| FROM python:3.9-slim | ||
|
|
||
| ARG DEV_MODE=dev | ||
| ARG POETRY_EXTRAS="" | ||
| ARG NLP_CONF_FILE=presidio_analyzer/conf/default.yaml | ||
| ARG ANALYZER_CONF_FILE=presidio_analyzer/conf/default_analyzer.yaml | ||
| ARG RECOGNIZER_REGISTRY_CONF_FILE=presidio_analyzer/conf/default_recognizers.yaml | ||
|
|
||
| ENV DEV_MODE=${DEV_MODE} | ||
| ENV PIP_NO_CACHE_DIR=1 | ||
| ENV ANALYZER_CONF_FILE=${ANALYZER_CONF_FILE} | ||
| ENV RECOGNIZER_REGISTRY_CONF_FILE=${RECOGNIZER_REGISTRY_CONF_FILE} | ||
| ENV NLP_CONF_FILE=${NLP_CONF_FILE} | ||
| ENV POETRY_EXTRAS=${POETRY_EXTRAS} | ||
|
|
||
| # Install essential build tools | ||
| RUN apt-get update \ | ||
| && apt-get install -y build-essential | ||
|
|
||
| RUN pip install poetry |
Check notice
Code scanning / checkov
Ensure that a user for the container has been created Note
SharonHart
approved these changes
Sep 10, 2024
omri374
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
added the ability to work on a dev container for each project.
Just launch "Reopen in container" in vscode and then choose between the different options.
Issue reference
This PR fixes issue #XX
Checklist