Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex match_time output #1488

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

andrewisplinghoff
Copy link
Contributor

@andrewisplinghoff andrewisplinghoff commented Nov 26, 2024

Change Description

The microseconds were output incorrectly before (missing leading zeros). Also, seconds was used instead of total_seconds (should be irrelevant in practice, though).

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@omri374
Copy link
Contributor

omri374 commented Nov 27, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Nov 27, 2024

Hi @andrewisplinghoff, thanks for this fix. In order to accept it, would you be able to sign the CLA?

@andrewisplinghoff
Copy link
Contributor Author

Hi @andrewisplinghoff, thanks for this fix. In order to accept it, would you be able to sign the CLA?

Sure, isn't it here via the PR? I expected to get some message. If suffcient: yes, I agree with the CLA.

@omri374 omri374 merged commit 3d9cee9 into microsoft:main Dec 1, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants