Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mkdocs html redirection, setting use_directory_urls #570

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

SharonHart
Copy link
Contributor

@SharonHart SharonHart commented Feb 28, 2021

Set use_directory_urls to false, to allow rest api html redirection
@navalev Can you push to your fork so that we'll validate it first there?

@navalev
Copy link
Contributor

navalev commented Feb 28, 2021

@SharonHart my fork is updated as of 2 hours ago. do u want me to use this branch?

@SharonHart
Copy link
Contributor Author

@navalev yes please

@navalev
Copy link
Contributor

navalev commented Feb 28, 2021

@SharonHart done

@navalev
Copy link
Contributor

navalev commented Feb 28, 2021

what should be the difference?

@omri374
Copy link
Contributor

omri374 commented Feb 28, 2021

@navalev the redoc swagger didn't work in all cases.

@navalev
Copy link
Contributor

navalev commented Feb 28, 2021

still doesnt seem to work in the fork

@SharonHart
Copy link
Contributor Author

SharonHart commented Feb 28, 2021

@navalev Thanks, will keep investigating. Locally everything works for me, and it also used to work on gh pages

@omri374 omri374 merged commit bd08038 into main Mar 1, 2021
@navalev navalev deleted the bug/fix-mkdocs-redirection branch April 4, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants