Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional analyzer examples #605

Merged
merged 5 commits into from
Mar 11, 2021
Merged

Additional analyzer examples #605

merged 5 commits into from
Mar 11, 2021

Conversation

omri374
Copy link
Contributor

@omri374 omri374 commented Mar 10, 2021 •
edited
Loading

  1. Added a jupyter notebook with additional examples of adding recognizers and handling analyser params. link.
  2. Added 3rd party notice for the mkdocs packages
  3. jupyter notebook integration into mkdocs

navalev
navalev requested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@navalev navalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the same mkdocs jupiter support to the simple scenario jupiter notebook?

@omri374 @navalev
Update docs/samples/python/index.md
6533e18 
Co-authored-by: Nava Vaisman Levy <[email protected]>
@omri374
Copy link
Contributor Author

omri374 commented Mar 11, 2021

@navalev thanks, missed this one.

shiranr
shiranr reviewed Mar 11, 2021
View reviewed changes
Copy link
Contributor

@shiranr shiranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some alignment comments.

@omri374 omri374 merged commit ea85b71 into main Mar 11, 2021
@navalev navalev deleted the sample/analyzer_example_scenarios branch April 4, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiranr shiranr shiranr approved these changes

@navalev navalev navalev approved these changes

@SharonHart SharonHart Awaiting requested review from SharonHart

@balteravishay balteravishay Awaiting requested review from balteravishay

@itye-msft itye-msft Awaiting requested review from itye-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omri374 @shiranr @navalev