-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two new samples + docs refactoring #744
Conversation
@@ -0,0 +1,171 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice usage of the lambda operator for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! run the 2 notebooks and all good :)
@@ -62,7 +63,8 @@ theme: | |||
favicon: assets/ms_icon.png | |||
features: | |||
- navigation.instant | |||
- navigation.tabs | |||
# - navigation.tabs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the tabs above are hidden if you scroll. The only way to get them to stay is to upgrade mkdocs-material to the Insiders version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! adds lots of great functionality. I don't see why not to merge it to the source code...
Change Description
Added two samples:
Updated documentation:
Issue reference
This PR provides examples for issues #742, #600, #609
Checklist