Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two new samples + docs refactoring #744

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Two new samples + docs refactoring #744

merged 3 commits into from
Jul 14, 2021

Conversation

omri374
Copy link
Contributor

@omri374 omri374 commented Jul 14, 2021

Change Description

Added two samples:

  1. Batch processing (sample uses Pandas DataFrames)
  2. Getting the text using a custom Operator

Updated documentation:

  1. Added section on replacing the NLP model
  2. Bug fixes
  3. Moved the menu to the left as it gets hidden (pinning it is not supported by the default mkdocs-material package, only via the Insiders version)

Issue reference

This PR provides examples for issues #742, #600, #609

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@@ -0,0 +1,171 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usage of the lambda operator for this!

Copy link
Contributor

@navalev navalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! run the 2 notebooks and all good :)

@@ -62,7 +63,8 @@ theme:
favicon: assets/ms_icon.png
features:
- navigation.instant
- navigation.tabs
# - navigation.tabs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the tabs above are hidden if you scroll. The only way to get them to stay is to upgrade mkdocs-material to the Insiders version.

Copy link
Contributor

@SharonHart SharonHart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! adds lots of great functionality. I don't see why not to merge it to the source code...

@omri374 omri374 merged commit 67cb019 into main Jul 14, 2021
@SharonHart SharonHart deleted the docs/batch_data_sample branch July 14, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants