-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[protobuf] Add Compiler Condition to use inline assembly optimizations with ARM64 #40173
Merged
BillyONeal
merged 20 commits into
microsoft:master
from
dsmith111:smithdavi/msvc-arm64-protobuf-gnu-patch
Aug 1, 2024
Merged
[protobuf] Add Compiler Condition to use inline assembly optimizations with ARM64 #40173
BillyONeal
merged 20 commits into
microsoft:master
from
dsmith111:smithdavi/msvc-arm64-protobuf-gnu-patch
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@LilyWangLL, just an FYI regarding the "Notify upstream owners for upstream relevant patches" section and 30 day's notice skip in the maintainer's guide; the tagged upstream PR fix was approved by a protobuf maintainer. |
Looks like there's an approval upstream. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.Submitted PR and issue of patch for upstream:
protocolbuffers/protobuf#17665
protocolbuffers/protobuf#17671
Source supporting issue:
https://learn.microsoft.com/en-us/cpp/assembler/inline/writing-functions-with-inline-assembly?view=msvc-170