Skip to content

Run Selection/Line and Run File produce error when used consecutively #2997

Open
@AbhinavAjitsaria

Description

@AbhinavAjitsaria

Environment data

  • VS Code version: 1.28.2
  • Extension version: 2018.9.1
  • OS and version: Ubuntu 18.04
  • Python version: 3.6.6
  • Type of virtual environment used : venv

Actual behavior

  • After 'Run Selection/Line in Python terminal' once, if 'Run Python File in terminal' is used, the command tries to execute in the ongoing interpreter session invoked by the first 'Run'

  • After 'Run File in Python terminal' once, if 'Run Selection/Line in terminal' is used, the command tries to execute in the open shell session invoked by the first 'Run' directly without invoking the interpreter first

Expected behavior

  • Run Selection/Line in Python terminal should invoke the Python interpreter first if the terminal is open and its state has changed since last Run.
  • Run python file in terminal should close Python interpreter if it is currently open

Steps to reproduce:

  1. Write a basic python program and Run Selection/Line in Terrminal.
  2. Immediately after Step 1, Run File in Terminal.
    The options can be done in reverse order too. It produces and error too.

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

bootstrap-window.js:195 [uncaught exception]: TypeError: Cannot read property 'isWrapped' of undefined
onUnexpectedError @ bootstrap-window.js:195
(anonymous) @ bootstrap-window.js:38
emitOne @ events.js:116
emit @ events.js:211
window.onerror @ /usr/share/code/resources/electron.asar/renderer/init.js:147
i.globals.onerror @ workbench.main.js:sourcemap:1538
setTimeout (async)
Linkifier.linkifyRows @ Linkifier.ts:76
Terminal._queueLinkification @ Terminal.ts:1143
(anonymous) @ Terminal.ts:619
EventEmitter.emit @ EventEmitter.ts:74
Renderer._renderRows @ Renderer.ts:199
RenderDebouncer._innerRefresh @ RenderDebouncer.ts:49
(anonymous) @ RenderDebouncer.ts:40
requestAnimationFrame (async)
RenderDebouncer.refresh @ RenderDebouncer.ts:40
Renderer.refreshRows @ Renderer.ts:190
Terminal.refresh @ Terminal.ts:1132
Renderer.onIntersectionChange @ Renderer.ts:87
t._resize @ workbench.main.js:sourcemap:3549
t.layout @ workbench.main.js:sourcemap:3548
t.setVisible @ workbench.main.js:sourcemap:3542
(anonymous) @ workbench.main.js:sourcemap:3641
t.setVisible @ workbench.main.js:sourcemap:3641
(anonymous) @ workbench.main.js:sourcemap:3648
e.setActiveInstanceByIndex @ workbench.main.js:sourcemap:3648
e.setActiveInstance @ workbench.main.js:sourcemap:3647
e.$show @ workbench.main.js:sourcemap:3251
t._doInvokeHandler @ workbench.main.js:sourcemap:3267
t._invokeHandler @ workbench.main.js:sourcemap:3266
t._receiveRequest @ workbench.main.js:sourcemap:3265
t._receiveOneMessage @ workbench.main.js:sourcemap:3264
(anonymous) @ workbench.main.js:sourcemap:3262
e.fire @ workbench.main.js:sourcemap:181
a @ workbench.main.js:sourcemap:318
n._socketDataListener @ workbench.main.js:sourcemap:318
emitOne @ events.js:116
emit @ events.js:211
addChunk @ _stream_readable.js:263
readableAddChunk @ _stream_readable.js:250
Readable.push @ _stream_readable.js:208
onread @ net.js:594
bootstrap-window.js:198 TypeError: Cannot read property 'isWrapped' of undefined
    at Buffer.getWrappedRangeForLine (Buffer.ts:302)
    at BufferStringIterator.next (Buffer.ts:421)
    at Linkifier._linkifyRows (Linkifier.ts:101)
    at Linkifier.ts:76
onUnexpectedError @ bootstrap-window.js:198
(anonymous) @ bootstrap-window.js:38
emitOne @ events.js:116
emit @ events.js:211
window.onerror @ /usr/share/code/resources/electron.asar/renderer/init.js:147
i.globals.onerror @ workbench.main.js:sourcemap:1538
setTimeout (async)
Linkifier.linkifyRows @ Linkifier.ts:76
Terminal._queueLinkification @ Terminal.ts:1143
(anonymous) @ Terminal.ts:619
EventEmitter.emit @ EventEmitter.ts:74
Renderer._renderRows @ Renderer.ts:199
RenderDebouncer._innerRefresh @ RenderDebouncer.ts:49
(anonymous) @ RenderDebouncer.ts:40
requestAnimationFrame (async)
RenderDebouncer.refresh @ RenderDebouncer.ts:40
Renderer.refreshRows @ Renderer.ts:190
Terminal.refresh @ Terminal.ts:1132
Renderer.onIntersectionChange @ Renderer.ts:87
t._resize @ workbench.main.js:sourcemap:3549
t.layout @ workbench.main.js:sourcemap:3548
t.setVisible @ workbench.main.js:sourcemap:3542
(anonymous) @ workbench.main.js:sourcemap:3641
t.setVisible @ workbench.main.js:sourcemap:3641
(anonymous) @ workbench.main.js:sourcemap:3648
e.setActiveInstanceByIndex @ workbench.main.js:sourcemap:3648
e.setActiveInstance @ workbench.main.js:sourcemap:3647
e.$show @ workbench.main.js:sourcemap:3251
t._doInvokeHandler @ workbench.main.js:sourcemap:3267
t._invokeHandler @ workbench.main.js:sourcemap:3266
t._receiveRequest @ workbench.main.js:sourcemap:3265
t._receiveOneMessage @ workbench.main.js:sourcemap:3264
(anonymous) @ workbench.main.js:sourcemap:3262
e.fire @ workbench.main.js:sourcemap:181
a @ workbench.main.js:sourcemap:318
n._socketDataListener @ workbench.main.js:sourcemap:318
emitOne @ events.js:116
emit @ events.js:211
addChunk @ _stream_readable.js:263
readableAddChunk @ _stream_readable.js:250
Readable.push @ _stream_readable.js:208
onread @ net.js:594
Buffer.ts:302 Uncaught TypeError: Cannot read property 'isWrapped' of undefined
    at Buffer.getWrappedRangeForLine (Buffer.ts:302)
    at BufferStringIterator.next (Buffer.ts:421)
    at Linkifier._linkifyRows (Linkifier.ts:101)
    at Linkifier.ts:76
Buffer.getWrappedRangeForLine @ Buffer.ts:302
BufferStringIterator.next @ Buffer.ts:421
Linkifier._linkifyRows @ Linkifier.ts:101
(anonymous) @ Linkifier.ts:76
setTimeout (async)
Linkifier.linkifyRows @ Linkifier.ts:76
Terminal._queueLinkification @ Terminal.ts:1143
(anonymous) @ Terminal.ts:619
EventEmitter.emit @ EventEmitter.ts:74
Renderer._renderRows @ Renderer.ts:199
RenderDebouncer._innerRefresh @ RenderDebouncer.ts:49
(anonymous) @ RenderDebouncer.ts:40
requestAnimationFrame (async)
RenderDebouncer.refresh @ RenderDebouncer.ts:40
Renderer.refreshRows @ Renderer.ts:190
Terminal.refresh @ Terminal.ts:1132
Renderer.onIntersectionChange @ Renderer.ts:87
t._resize @ workbench.main.js:sourcemap:3549
t.layout @ workbench.main.js:sourcemap:3548
t.setVisible @ workbench.main.js:sourcemap:3542
(anonymous) @ workbench.main.js:sourcemap:3641
t.setVisible @ workbench.main.js:sourcemap:3641
(anonymous) @ workbench.main.js:sourcemap:3648
e.setActiveInstanceByIndex @ workbench.main.js:sourcemap:3648
e.setActiveInstance @ workbench.main.js:sourcemap:3647
e.$show @ workbench.main.js:sourcemap:3251
t._doInvokeHandler @ workbench.main.js:sourcemap:3267
t._invokeHandler @ workbench.main.js:sourcemap:3266
t._receiveRequest @ workbench.main.js:sourcemap:3265
t._receiveOneMessage @ workbench.main.js:sourcemap:3264
(anonymous) @ workbench.main.js:sourcemap:3262
e.fire @ workbench.main.js:sourcemap:181
a @ workbench.main.js:sourcemap:318
n._socketDataListener @ workbench.main.js:sourcemap:318
emitOne @ events.js:116
emit @ events.js:211
addChunk @ _stream_readable.js:263
readableAddChunk @ _stream_readable.js:250
Readable.push @ _stream_readable.js:208
onread @ net.js:594

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-editor-*User-facing catch-allarea-replbugIssue identified by VS Code Team member as probable bugneeds proposalNeed to make some design decisions

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions