Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL SSL support #1044

Merged
merged 14 commits into from
Nov 21, 2023
Merged

PostgreSQL SSL support #1044

merged 14 commits into from
Nov 21, 2023

Conversation

fare
Copy link
Collaborator

@fare fare commented Nov 17, 2023

Add support for SSL in PostgreSQL client

@netlify Netlify
Copy link

netlify bot commented Nov 17, 2023 •
edited
Loading

✅ Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit 8febe04
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/655c9e3883fb5f0008be88e9
😎 Deploy Preview https://deploy-preview-1044--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fare
Copy link
Collaborator Author

fare commented Nov 17, 2023

It looks like I'm getting closer, but I must be doing the reset wrong still, or something, because after a seemingly successful SSL negotiation (albeit in insecure context), I get:

*** ERROR IN std/db/postgresql#postgresql-connect__% --
*** ERROR IN "db/postgresql-driver.ss"@622.27-622.43 [IOError]: unexpected backend message
--- irritants: postgresql-recv! 23

23 is definitely not part of the protocol, and I don't suppose the bug is server side, so presumably my reset! didn't do the right thing and my buffer is now out of sync. Please advise @vyzo

@fare fare changed the base branch from master to cli November 17, 2023 04:10
@fare fare changed the title [WIP] PostgreSQL SSL support PostgreSQL SSL support Nov 17, 2023
@fare
Copy link
Collaborator Author

fare commented Nov 17, 2023

I had misunderstood the ssl-client-upgrade API and was simply seeing the SSL frames. Everything now OK.

@fare fare changed the base branch from cli to master November 17, 2023 07:52
@fare fare enabled auto-merge (squash) November 17, 2023 07:52
@vyzo
Copy link
Collaborator

vyzo commented Nov 18, 2023

netlify build failed

@vyzo
Copy link
Collaborator

vyzo commented Nov 18, 2023

and CI build...

@fare
Copy link
Collaborator Author

fare commented Nov 18, 2023

Had to fix the defaults. Works for me now. PTAL.

vyzo
vyzo reviewed Nov 18, 2023
View reviewed changes
@fare
Copy link
Collaborator Author

fare commented Nov 19, 2023

PTAL

@vyzo
Copy link
Collaborator

vyzo commented Nov 19, 2023

CI did not run...

vyzo
vyzo requested changes Nov 19, 2023
View reviewed changes
@fare
Copy link
Collaborator Author

fare commented Nov 20, 2023

PTAL

@fare fare requested a review from vyzo November 20, 2023 14:28
vyzo
vyzo reviewed Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just a couple of comments.

@fare fare merged commit 8dd0e65 into master Nov 21, 2023
@fare fare deleted the psql branch November 21, 2023 12:41
drewc pushed a commit to drewc/gerbil that referenced this pull request Nov 29, 2023
@fare @drewc
PostgreSQL SSL support (mighty-gerbils#1044)
fde4d6c 
Add support for SSL in PostgreSQL client
@BrewTestBot BrewTestBot mentioned this pull request Dec 6, 2023
Closed
This was referenced Feb 24, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fare @vyzo