-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename, test, fix, and document the LL(1) parser combinator library #1063
Conversation
std/text/basic-parsers => std/parser/ll1-parser
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is pure refactoring, lets go the full monty and move the modules in std/parser into std/parser/lang.
Note: you'll need to update documentation and the custom lang tutorial as well.
also, lets not repeat the word parser, so std/parser/basic? |
I admit I don't understand what move exactly you want and what it has to do with lang. Call? For the immediate rename—I will rename to just |
It finally passes tests, after all the renaming and API shuffling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! thank you for keeping the API for parse-decimal.
std/text/basic-parsers => std/parser/ll1