Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename, test, fix, and document the LL(1) parser combinator library #1063

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Conversation

fare
Copy link
Collaborator

@fare fare commented Dec 3, 2023

std/text/basic-parsers => std/parser/ll1

std/text/basic-parsers => std/parser/ll1-parser
@fare fare requested review from vyzo and drewc December 3, 2023 18:46
Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit 3100374
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/656d38898b28cd0008ea98d3
😎 Deploy Preview https://deploy-preview-1063--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fare
Copy link
Collaborator Author

fare commented Dec 3, 2023

Requesting technical review from @drewc and overall module naming review from @vyzo

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is pure refactoring, lets go the full monty and move the modules in std/parser into std/parser/lang.

Note: you'll need to update documentation and the custom lang tutorial as well.

@vyzo
Copy link
Collaborator

vyzo commented Dec 3, 2023

also, lets not repeat the word parser, so std/parser/basic?

@fare
Copy link
Collaborator Author

fare commented Dec 3, 2023

I admit I don't understand what move exactly you want and what it has to do with lang. Call?

For the immediate rename—I will rename to just std/parser/ll1. This part I got.

@fare
Copy link
Collaborator Author

fare commented Dec 3, 2023

It finally passes tests, after all the renaming and API shuffling.

Copy link
Collaborator

@drewc drewc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thank you for keeping the API for parse-decimal.

@fare fare enabled auto-merge (squash) December 4, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants