std/misc/func: pred-and & pred-or #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
May 23, 2020
thibran
force-pushed
the
misc/func/pred-and-pred-or
branch
from
0616516 to
a6bb977
Compare
|
I was actually thinking of not invoking the predicate at all if we are short-circuiting; not sure if it can be written with chain though. |
thibran
force-pushed
the
misc/func/pred-and-pred-or
branch
from
a6bb977 to
eade74b
Compare
vyzo
reviewed
May 23, 2020
src/std/misc/func.ss
Outdated
| (def (pred-and pred) | ||
| (def res #t) | ||
| (lambda (v) | ||
| (match res |
There was a problem hiding this comment.
we don't quite need match here, just an if will do :)
src/std/misc/func.ss
Outdated
| (def res #t) | ||
| (lambda (v) | ||
| (match res | ||
| (#t (set! res (and res (pred v))) res) |
There was a problem hiding this comment.
no need to and, it's already #t.
src/std/misc/func.ss
Outdated
| (def (pred-or pred) | ||
| (def res #f) | ||
| (lambda (v) | ||
| (match res |
src/std/misc/func.ss
Outdated
| (def res #f) | ||
| (lambda (v) | ||
| (match res | ||
| (#f (set! res (or res (pred v))) res) |
There was a problem hiding this comment.
and here the or is unnecessary.
There was a problem hiding this comment.
haha, yeah, I have mornings like that too...
thibran
force-pushed
the
misc/func/pred-and-pred-or
branch
from
eade74b to
825411e
Compare
thibran
force-pushed
the
misc/func/pred-and-pred-or
branch
from
825411e to
01cb74a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pred-andallows to check if apredholds on multiple circumstances without constructing a filtered list of to-be-checked items beforehand.