Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL Simple Query, revise -statement with -command #640

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

drewc
Copy link
Collaborator

@drewc drewc commented Nov 19, 2021

Here is my most recent version. I tried to do a proper subtree with history but it didn't work out so here are the changes in "order": gerbil-postgresql

Also this master has some small changes to ./configure that are in this pull request because I couldn't figure out how to remove them. Sigh. :)

@vyzo
Copy link
Collaborator

vyzo commented Nov 19, 2021 via email

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of comments

@vyzo vyzo requested a review from fare November 19, 2021 18:27
@drewc drewc force-pushed the master branch 2 times, most recently from 83e281f to 73d1c05 Compare November 19, 2021 20:38
@vyzo
Copy link
Collaborator

vyzo commented Nov 19, 2021

can you cherry pick the log changes into a separate pr?

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor comments, otherwise LGTM

(again)))))
(else
(when greedy-in (channel-sync greedy-in next))
;; (display "greed?: " )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get rid of this debug code?

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, lets merge it.

@vyzo vyzo merged commit b706f58 into mighty-gerbils:master Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants