-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostgreSQL Simple Query, revise -statement with -command #640
Conversation
do `git rebase` ro get rid of the merged commits.
…On Fri, Nov 19, 2021, 20:14 Drew Crampsie ***@***.***> wrote:
Here is my most recent version. I tried to do a proper subtree with
history but it didn't work out so here are the changes in "order":
gerbil-postgresql <https://github.com/drewc/gerbil-postgresql>
Also this master has some small changes to ./configure that are in this
pull request because I couldn't figure out how to remove them. Sigh. :)
------------------------------
You can view, comment on, or merge this pull request online at:
#640
Commit Summary
- f3fd3dd
<f3fd3dd>
Change PACKAGE_[s/STRING/VERSION/] for gx-version.
- 89766cc
<89766cc>
Add a proper PACKAGE_TARNAME "Just In Case"(c)
- 86269c9
<86269c9>
Merge branch 'vyzo:master' into master
- 0c44107
<0c44107>
Merge branch 'vyzo:master' into master
- 408072c
<408072c>
Add new postgresql-query, postgresql-command
File Changes
(3 files <https://github.com/vyzo/gerbil/pull/640/files>)
- *M* src/std/db/postgresql-driver.ss
<https://github.com/vyzo/gerbil/pull/640/files#diff-5b8d712a4b1c632b944e957c1b6f673ea55bb75329d762876b4821c24951da01>
(206)
- *M* src/std/db/postgresql-test.ss
<https://github.com/vyzo/gerbil/pull/640/files#diff-4ae3f60a4a3fcba103f37c89b3652e0254558c3ef25036e4321a5b38c5660a86>
(154)
- *M* src/std/db/postgresql.ss
<https://github.com/vyzo/gerbil/pull/640/files#diff-4e6bb2f42a04f02998ab0c779213ae33f79f928aca7e53333eea58c6e0a70eea>
(265)
Patch Links:
- https://github.com/vyzo/gerbil/pull/640.patch
- https://github.com/vyzo/gerbil/pull/640.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#640>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAI4SWYV4ASTPNUTBLOH53UM2HXNANCNFSM5IMXGODA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of comments
83e281f
to
73d1c05
Compare
can you cherry pick the log changes into a separate pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor comments, otherwise LGTM
src/std/db/postgresql.ss
Outdated
(again))))) | ||
(else | ||
(when greedy-in (channel-sync greedy-in next)) | ||
;; (display "greed?: " ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get rid of this debug code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, lets merge it.
Here is my most recent version. I tried to do a proper subtree with history but it didn't work out so here are the changes in "order": gerbil-postgresql
Also this master has some small changes to ./configure that are in this pull request because I couldn't figure out how to remove them. Sigh. :)