Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: upgrade go arrow version from 12.0.1 to 17.0.0 #39916

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: upgrade go arrow version from 12.0.1 to 17.0.0 #39916

wants to merge 1 commit into from

Conversation

shaoting-huang
Copy link
Contributor

related: #39915

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaoting-huang
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file area/test sig/testing test/integration integration test labels Feb 17, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 17, 2025
@dosubot dosubot bot added the go Pull requests that update Go code label Feb 17, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 17, 2025

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.61%. Comparing base (38f1608) to head (9e21abc).
Report is 2 commits behind head on master.

❗ Current head 9e21abc differs from pull request most recent head b99529f

Please upload reports for the commit b99529f to get more accurate results.

❌ Your project check has failed because the head coverage (69.61%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39916      +/-   ##
==========================================
- Coverage   69.85%   69.61%   -0.24%     
==========================================
  Files         309      307       -2     
  Lines       27573    27491      -82     
==========================================
- Hits        19262    19139     -123     
- Misses       8311     8352      +41
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.61% <ø> (-0.24%) ⬇️
Go ∅ <ø> (∅)

see 7 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 17, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 17, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

tedxu
tedxu reviewed Feb 18, 2025
View reviewed changes
go.mod
@@ -279,7 +279,6 @@ require (
)

replace (
github.com/apache/arrow/go/v12 => github.com/milvus-io/arrow/go/v12 v12.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any context on using a homebrew arrow?

@mergify mergify bot added the ci-passed label Feb 18, 2025
@shaoting-huang shaoting-huang changed the title enhance: upgrade go arrow version from 12.0.1 to 17.0.0 enhance: upgrade go arrow version from 12.0.1 to 18.1.0 Feb 19, 2025
@mergify mergify bot removed the ci-passed label Feb 19, 2025
@sre-ci-robot sre-ci-robot added area/compilation size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Feb 19, 2025
@sre-ci-robot sre-ci-robot removed the size/XXL Denotes a PR that changes 1000+ lines. label Feb 19, 2025
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 19, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 19, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang shaoting-huang changed the title enhance: upgrade go arrow version from 12.0.1 to 18.1.0 enhance: upgrade go arrow version from 12.0.1 to 17.0.0 Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedxu tedxu tedxu left review comments

@congqixia congqixia Awaiting requested review from congqixia

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees
No one assigned
Labels
area/compilation area/dependency Pull requests that update a dependency file area/test dco-passed DCO check passed. go Pull requests that update Go code kind/enhancement Issues or changes related to enhancement sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaoting-huang @sre-ci-robot @tedxu