Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Accelerate listing objects during binlog import #40049

Open
wants to merge 3 commits into
base: 2.4
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

issue: #40030

pr: #40047

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Feb 20, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 20, 2025
Copy link
Contributor

mergify bot commented Feb 20, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.33%. Comparing base (d223150) to head (8eaabe6).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #40049       +/-   ##
===========================================
+ Coverage   70.40%   83.33%   +12.93%     
===========================================
  Files        1081      813      -268     
  Lines      170485   144026    -26459     
===========================================
- Hits       120027   120025        -2     
+ Misses      45932    19471    -26461     
- Partials     4526     4530        +4     
Files with missing lines Coverage Δ
internal/datacoord/services.go 85.44% <100.00%> (+0.16%) ⬆️

... and 292 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants