Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: clean shard location cache after collection released #40088

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

issue: #40077

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 21, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 21, 2025
Copy link
Contributor

mergify bot commented Feb 21, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (dd68814) to head (623bff1).
Report is 1 commits behind head on master.

Current head 623bff1 differs from pull request most recent head d9ddec4

Please upload reports for the commit d9ddec4 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40088       +/-   ##
===========================================
+ Coverage   69.85%   80.56%   +10.70%     
===========================================
  Files         309     1465     +1156     
  Lines       27573   205416   +177843     
===========================================
+ Hits        19262   165492   +146230     
- Misses       8311    33899    +25588     
- Partials        0     6025     +6025     
Components Coverage Δ
Client 79.25% <ø> (∅)
Core 69.61% <ø> (-0.24%) ⬇️
Go 82.40% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/job/job_release.go 81.51% <100.00%> (ø)

... and 1164 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 24, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the clean_shard_location_cache branch from 623bff1 to d9ddec4 Compare February 24, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants