Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change CMake variable for switch to knowhere-cuvs #40105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lowener
Copy link

@lowener lowener commented Feb 21, 2025

No description provided.

@sre-ci-robot
Copy link
Contributor

Welcome @lowener! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lowener
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 21, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Feb 21, 2025
Copy link
Contributor

mergify bot commented Feb 21, 2025

@lowener

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@lowener lowener changed the title Change CMake variable for switch to knowhere-cuvs fix: Change CMake variable for switch to knowhere-cuvs Feb 21, 2025
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Feb 21, 2025
Copy link
Contributor

mergify bot commented Feb 21, 2025

@lowener Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.87%. Comparing base (3eb3af5) to head (a7a83bd).
Report is 1 commits behind head on master.

❌ Your project check has failed because the head coverage (69.87%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (3eb3af5) and HEAD (a7a83bd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3eb3af5) HEAD (a7a83bd)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40105       +/-   ##
===========================================
- Coverage   80.61%   69.87%   -10.75%     
===========================================
  Files        1468      309     -1159     
  Lines      205585    27573   -178012     
===========================================
- Hits       165729    19266   -146463     
+ Misses      33836     8307    -25529     
+ Partials     6020        0     -6020     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.87% <ø> (+0.01%) ⬆️
Go ∅ <ø> (∅)

see 1160 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation area/knowhere dco-passed DCO check passed. do-not-merge/missing-related-issue kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants