ConvertTo-Shellcode against a DLL produces shellcode that hangs execution

[rkbennett]

When running either ConvertTo-Shellcode in powershell or ConvertToShellcode(dll) in python the resulting shellcode causes the terminal to hang. This happens when executing the shellcode via Invoke-Shellcode or running the shellcode via Python's ctypes library. For reference, the dll I'm testing with is from https://github.com/CuckooEXE/PopCalc. Seems like a pretty simple dll which is written in C++. Still looking at the system calls currently, will update if I see something out of place.

[DaWouw]

@rkbennett , it seems we also ran into this issue and were able to resolve it. See the mentioned PR.

[rkbennett]

Ah, okay I saw that Issue, but the way it described it made it sound like it was just slow not hung. I tried your changes and it 100% works for me now. Thank you!

[rkbennett]

Ah, I stand corrected, the example test dll works, but the dll from PopCalc will not hang, but doesn't spawn an instance of calc.

Actually I was wrong here, PopCalc had an ifdef statement which had to be removed, it works fine. My bad.