Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pinyin.Paragraph method for convert a paragraph into pinyin #37

Merged
merged 9 commits into from
Dec 5, 2019
Merged

Add pinyin.Paragraph method for convert a paragraph into pinyin #37

merged 9 commits into from
Dec 5, 2019

Conversation

huacnlee
Copy link
Contributor

@huacnlee huacnlee commented Dec 4, 2019 •
edited
Loading

Also support polyphone, keep letters, numbers, symbols.

  • phrase_dict.go 1.3M

golangcibot
golangcibot reviewed Dec 4, 2019
View reviewed changes
@coveralls
Copy link

coveralls commented Dec 4, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.09%) to 98.913% when pulling 2c8b708 on huacnlee:imporve-with-phrases into a1cd0b7 on mozillazg:develop.

golangcibot
golangcibot reviewed Dec 4, 2019
View reviewed changes
@huacnlee
Copy link
Contributor Author

huacnlee commented Dec 4, 2019

Fix #34 #3

@huacnlee huacnlee changed the title Add ParagraphPinyin for convert a paragraph into pinyin Add pinyin.Paragraph method for convert a paragraph into pinyin. Dec 4, 2019
@huacnlee huacnlee changed the title Add pinyin.Paragraph method for convert a paragraph into pinyin. Add pinyin.Paragraph method for convert a paragraph into pinyin Dec 4, 2019
@mozillazg mozillazg changed the base branch from master to develop December 5, 2019 05:25
@mozillazg
Copy link
Owner

@huacnlee Thank you for your work!

mozillazg
mozillazg reviewed Dec 5, 2019
View reviewed changes
@mozillazg mozillazg merged commit 842fd70 into mozillazg:develop Dec 5, 2019
@huacnlee
Copy link
Contributor Author

huacnlee commented Dec 5, 2019

麻烦尽快打个 Tag，我们项目里面最近要用这个东西

@huacnlee huacnlee deleted the imporve-with-phrases branch December 5, 2019 11:12
@mozillazg
Copy link
Owner

@huacnlee v0.16.0 已发布。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@mozillazg mozillazg mozillazg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huacnlee @coveralls @mozillazg @golangcibot