feat(tg): accept any http client what satisfies doer interface #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will makes possible usage of github.com/hashicorp/go-retryablehttp, any any http client which relies on some internal things and have different from http.Client struct return, but satisfies http interface
|
Actually wrong, go-retryablehttp cannot be used because of Request mismatch. Let me check. Edit: it has |
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 20 20
Lines 2406 2406
=======================================
Hits 2245 2245
Misses 126 126
Partials 35 35
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
It seems right to make Doer public. I'm not sure that godoc will be able to show the private interface correctly |
mr-linch
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will makes possible usage of go-retryablehttp, and any http client which relies on some internal things and have different from http.Client struct return, but satisfies http interface