Loaders: Replace JSZip and gunzip with fflate. #20959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101arrowz
reviewed
Dec 29, 2020
|
Okay, I've cleaned up the usage of fflate in |
101arrowz
approved these changes
Dec 29, 2020
|
This is awesome. You guys are the best! 🤗 |
|
Thanks! ✨ |
mrdoob
reviewed
Dec 29, 2020
| @@ -13,6 +13,7 @@ const assets = [ | |||
| '../examples/jsm/controls/TransformControls.js', | |||
|
|
|||
| '../examples/jsm/libs/chevrotain.module.min.js', | |||
| '../examples/jsm/libs/fflate.module.min.js', | |||
| '../examples/jsm/libs/inflate.module.min.js', | |||
| '../examples/jsm/libs/jszip.module.min.js', | |||
There was a problem hiding this comment.
Do we still need inflate and jszip there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixed #20941.
Description
This PR replaces the loader dependencies JSZip and gunzip with fflate.
To completely remove JSZip, it would be necessary to refactor some code in the editor (although I don't think this task is that urgent and can be done later).
It was also necessary to slightly enhance
modularize.jsso it's possible to convert the usage of fflate from js -> jsm.