Update dependency eslint to v9 - autoclosed

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
eslint (source)	^8.37.0 -> ^9.0.0

---

Release Notes

eslint/eslint (eslint)

v9.2.0

Compare Source

v9.1.1

Compare Source

v9.1.0

Compare Source

v9.0.0

Compare Source

---

Configuration

📅 Schedule: Branch creation - "after 1am and before 7am on monday" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[renovate]

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/eslint
npm error   dev eslint@"^9.0.0" from the root project
npm error   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/[email protected]
npm error   node_modules/@eslint-community/eslint-utils
npm error     @eslint-community/eslint-utils@"^4.2.0" from [email protected]
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0" from [email protected]
npm error node_modules/eslint-plugin-compat
npm error   dev eslint-plugin-compat@"^4.1.2" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/eslint
npm error   peer eslint@"^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0" from [email protected]
npm error   node_modules/eslint-plugin-compat
npm error     dev eslint-plugin-compat@"^4.1.2" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-05-12T19_07_50_168Z-eresolve-report.txt

npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-05-12T19_07_50_168Z-debug-0.log

[donmccurdy]

The main change in ESLint v9 is the move to flat configs, which are .js files rather than .json. We should eventually switch to a flat config in a separate PR first, they're supported in v8. Once the config is updated, this PR will pass tests and merge automatically. We currently use the following ESLint plugins...

• eslint-config-mdcs
• eslint-plugin-compat
• eslint-plugin-html
• eslint-plugin-import

... but none of them yet support the flat configs required in ESLint 9, so I think this will be blocked for a while.

[donmccurdy]

Let's block Renovate bot from making PRs for ESLint, until that situation improves:

• chore(lint): Add eslint to renovate bot's denylist #28356

I got partway through the migration to a flat config before hitting the issues above. In case it's helpful next time, here's the partially-upgraded config:

eslint.config.js

import globals from "globals";

export default [
  {
    files: ["**/*.js"],
    extends: ["mdcs", "plugin:compat/recommended"],
    plugins: ["html", "import"],
    settings: {
      polyfills: ["WebGL2RenderingContext"],
    },
    languageOptions: {
      ecmaVersion: 2018,
      sourceType: "module",
      globals: {
        ...globals.browser,
        ...globals.node,
        __THREE_DEVTOOLS__: "readonly",
        potpack: "readonly",
        fflate: "readonly",
        Stats: "readonly",
        XRWebGLBinding: "readonly",
        XRWebGLLayer: "readonly",
        GPUShaderStage: "readonly",
        GPUBufferUsage: "readonly",
        GPUTextureUsage: "readonly",
        GPUTexture: "readonly",
        GPUMapMode: "readonly",
        QUnit: "readonly",
        Ammo: "readonly",
        XRRigidTransform: "readonly",
        XRMediaBinding: "readonly",
        CodeMirror: "readonly",
        esprima: "readonly",
        jsonlint: "readonly",
        VideoFrame: "readonly",
      },
    },
    rules: {
      "no-throw-literal": ["error"],
      quotes: ["error", "single"],
      "prefer-const": [
        "error",
        {
          destructuring: "any",
          ignoreReadBeforeAssign: false,
        },
      ],
    },
  },
];