Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: remove useless call in WebGL fallback #29631

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

aardgoose
Copy link
Contributor

Related issue: #29622

The call to createBindings() call doesn't do anything, bindings are already created at this point.
Remove call and also the now pointless check for this null.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.92
170.93
689.92
170.93
+0 B
+0 B
WebGPU 814.86
219.4
814.81
219.39
-47 B
-17 B
WebGPU Nodes 814.36
219.27
814.32
219.25
-47 B
-17 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.94
111.81
462.94
111.81
+0 B
+0 B
WebGPU 537.67
145.07
537.62
145.06
-47 B
-17 B
WebGPU Nodes 493.78
134.81
493.74
134.79
-47 B
-17 B

@Mugen87 Mugen87 added this to the r170 milestone Oct 12, 2024
@Mugen87 Mugen87 merged commit 1886e4b into mrdoob:dev Oct 12, 2024
12 checks passed
@aardgoose aardgoose deleted the remove-useless-call branch November 6, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants