Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix pipeline cache key #29685

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 18, 2024

Related issue: Fixes #29683

Description

Fixed shared pipeline across different geometry setup.

@sunag sunag added this to the r170 milestone Oct 18, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 690.8
171.12
690.8
171.12
+0 B
+0 B
WebGPU 816.43
220.08
816.46
220.09
+24 B
+10 B
WebGPU Nodes 815.94
219.95
815.97
219.96
+24 B
+10 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 463.45
111.9
463.45
111.9
+0 B
+0 B
WebGPU 538.61
145.41
538.64
145.42
+24 B
+9 B
WebGPU Nodes 494.73
135.28
494.75
135.28
+24 B
+9 B

@sunag sunag marked this pull request as ready for review October 18, 2024 02:16
@sunag sunag merged commit 076d8d6 into mrdoob:dev Oct 18, 2024
12 checks passed
@sunag sunag deleted the dev-pipeline-fix branch October 18, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPURenderer: Broken mesh rendering when using normalized, interleaved attributes.
1 participant