New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhysicalLightingModel: Cleanup `evalIridescence` #29702

Merged

sunag merged 1 commit into mrdoob:dev from sunag:dev-cleanup-3

Oct 20, 2024

Collaborator

sunag commented Oct 20, 2024

Description

Using Loop() should simplify code generation.


          cleanup

b885171

sunag marked this pull request as ready for review

October 20, 2024 04:11

sunag added this to the r170 milestone

github-actions bot commented Oct 20, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	692.42 171.34	692.42 171.34	+0 B +0 B
WebGPU	816.84 220.03	816.92 220.02	+83 B -9 B
WebGPU Nodes	816.35 219.9	816.43 219.89	+83 B -7 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	464.65 112.12	464.65 112.12	+0 B +0 B
WebGPU	538.6 145.39	538.68 145.4	+83 B +8 B
WebGPU Nodes	494.71 135.27	494.71 135.27	+0 B +0 B

sunag merged commit 16f2c3e into mrdoob:dev

12 checks passed

sunag deleted the dev-cleanup-3 branch

October 20, 2024 04:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet