Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostProcessing: Harmonize node type. #29823

Merged
merged 1 commit into from
Nov 6, 2024
Merged

PostProcessing: Harmonize node type. #29823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/AfterImageNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class AfterImageNode extends TempNode {

constructor( textureNode, damp = 0.96 ) {

super( textureNode );
super( 'vec4' );

this.textureNode = textureNode;
this.textureNodeOld = texture();
Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/BloomNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class BloomNode extends TempNode {

constructor( inputNode, strength = 1, radius = 0, threshold = 0 ) {

super();
super( 'vec4' );

this.inputNode = inputNode;
this.strength = uniform( strength );
Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/DenoiseNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class DenoiseNode extends TempNode {

constructor( textureNode, depthNode, normalNode, noiseNode, camera ) {

super();
super( 'vec4' );

this.textureNode = textureNode;
this.depthNode = depthNode;
Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/DepthOfFieldNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class DepthOfFieldNode extends TempNode {

constructor( textureNode, viewZNode, focusNode, apertureNode, maxblurNode ) {

super();
super( 'vec4' );

this.textureNode = textureNode;
this.viewZNode = viewZNode;
Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/FXAANode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class FXAANode extends TempNode {

constructor( textureNode ) {

super();
super( 'vec4' );

this.textureNode = textureNode;

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/FilmNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class FilmNode extends TempNode {

constructor( inputNode, intensityNode = null, uvNode = null ) {

super();
super( 'vec4' );

this.inputNode = inputNode;
this.intensityNode = intensityNode;
Expand Down
6 changes: 5 additions & 1 deletion examples/jsm/tsl/display/GTAONode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ const _size = /*@__PURE__*/ new Vector2();

let _rendererState;

/**
* References:
* https://www.activision.com/cdn/research/Practical_Real_Time_Strategies_for_Accurate_Indirect_Occlusion_NEW%20VERSION_COLOR.pdf
*/
class GTAONode extends TempNode {

static get type() {
Expand All @@ -16,7 +20,7 @@ class GTAONode extends TempNode {

constructor( depthNode, normalNode, camera ) {

super();
super( 'vec4' );

this.depthNode = depthNode;
this.normalNode = normalNode;
Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/LensflareNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class LensflareNode extends TempNode {

constructor( textureNode, params = {} ) {

super();
super( 'vec4' );

this.textureNode = textureNode;

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/Lut3DNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class Lut3DNode extends TempNode {

constructor( inputNode, lutNode, size, intensityNode ) {

super();
super( 'vec4' );

this.inputNode = inputNode;
this.lutNode = lutNode;
Expand Down
4 changes: 2 additions & 2 deletions examples/jsm/tsl/display/PixelationPassNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class PixelationNode extends TempNode {

constructor( textureNode, depthNode, normalNode, pixelSize, normalEdgeStrength, depthEdgeStrength ) {

super();
super( 'vec4' );

// Input textures

Expand Down Expand Up @@ -158,7 +158,7 @@ class PixelationPassNode extends PassNode {

constructor( scene, camera, pixelSize = 6, normalEdgeStrength = 0.3, depthEdgeStrength = 0.4 ) {

super( 'color', scene, camera, { minFilter: NearestFilter, magFilter: NearestFilter } );
super( PassNode.COLOR, scene, camera, { minFilter: NearestFilter, magFilter: NearestFilter } );

this.pixelSize = pixelSize;
this.normalEdgeStrength = normalEdgeStrength;
Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/SMAANode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class SMAANode extends TempNode {

constructor( textureNode ) {

super();
super( 'vec4' );

this.textureNode = textureNode;

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/SSRNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class SSRNode extends TempNode {

constructor( colorNode, depthNode, normalNode, metalnessNode, camera ) {

super();
super( 'vec4' );

this.colorNode = colorNode;
this.depthNode = depthNode;
Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/SobelOperatorNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class SobelOperatorNode extends TempNode {

constructor( textureNode ) {

super();
super( 'vec4' );

this.textureNode = textureNode;

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/tsl/display/TransitionNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class TransitionNode extends TempNode {

constructor( textureNodeA, textureNodeB, mixTextureNode, mixRatioNode, thresholdNode, useTextureNode ) {

super();
super( 'vec4' );

// Input textures

Expand Down