Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSLNodeBuilder: Fix varying color type #29950

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 23, 2024

Description

Fix type conversion if used varying in WebGL Backend.

material.colorNode = uniform( color( 0x00ff00 ) ).varying();

/cc @brunosimon

@sunag sunag added this to the r171 milestone Nov 23, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.13
79
339.13
79
+0 B
+0 B
WebGPU 482.81
133.76
482.84
133.77
+28 B
+8 B
WebGPU Nodes 482.27
133.66
482.3
133.67
+28 B
+9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.59
111.96
464.59
111.96
+0 B
+0 B
WebGPU 550.87
149.23
550.9
149.24
+28 B
+8 B
WebGPU Nodes 506.75
138.95
506.78
138.96
+28 B
+8 B

@sunag sunag marked this pull request as ready for review November 23, 2024 18:27
@sunag sunag merged commit 05cfdd9 into mrdoob:dev Nov 23, 2024
12 checks passed
@sunag sunag deleted the dev-varying-type branch November 23, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant