Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial: Fix getAlphaHashThreshold() properties conflict #29977

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 27, 2024

Description

Remove variable conflicts for now until we create an auto-naming system.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.14
78.99
339.14
78.99
+0 B
+0 B
WebGPU 483.59
134.17
483.57
134.16
-15 B
-12 B
WebGPU Nodes 483.06
134.07
483.04
134.06
-15 B
-12 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.62
111.98
464.62
111.98
+0 B
+0 B
WebGPU 552.72
149.52
552.7
149.51
-15 B
-16 B
WebGPU Nodes 508.6
139.24
508.58
139.23
-15 B
-14 B

@sunag sunag marked this pull request as ready for review November 27, 2024 06:00
@sunag sunag merged commit 269e892 into mrdoob:dev Nov 27, 2024
12 checks passed
@sunag sunag deleted the dev-fix-names branch November 27, 2024 06:01
@sunag sunag added this to the r171 milestone Nov 27, 2024
cmhhelgeson pushed a commit to cmhhelgeson/three.js that referenced this pull request Dec 5, 2024
…ob#29977)

* Fix `getAlphaHashThreshold()` properties conflict

* cleanup
@sunag sunag mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant