Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniformArrayNode: add support for mat2, mat3 and mat4 types #30051

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

holtsetio
Copy link
Contributor

Description

This change adds support for mat2, mat3 and mat4 datatypes in uniform arrays which was missing before. mat3 values are uploaded as mat4 to ensure 16 byte alignment.

Copy link

github-actions bot commented Dec 6, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.11
78.98
339.11
78.98
+0 B
+0 B
WebGPU 484.85
134.59
485.33
134.73
+485 B
+134 B
WebGPU Nodes 484.31
134.5
484.8
134.63
+485 B
+133 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465
112.04
465
112.04
+0 B
+0 B
WebGPU 554.24
150.04
554.72
150.17
+485 B
+123 B
WebGPU Nodes 510.12
139.75
510.61
139.88
+485 B
+120 B

@Mugen87 Mugen87 added this to the r172 milestone Dec 7, 2024
@sunag sunag merged commit 58a9949 into mrdoob:dev Dec 7, 2024
12 checks passed
@holtsetio holtsetio deleted the matrixUniformArrays branch December 7, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants