Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShadowNode: Fix updateMatrices sequence #30064

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 8, 2024

Related issue: Fixes #30053 (comment)

Description

Fix updateMatrices sequence.

@sunag sunag added this to the r172 milestone Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.11
78.98
339.11
78.98
+0 B
+0 B
WebGPU 485.96
134.92
486.01
134.92
+47 B
+4 B
WebGPU Nodes 485.43
134.82
485.48
134.83
+47 B
+4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465
112.04
465
112.04
+0 B
+0 B
WebGPU 555.36
150.4
555.41
150.39
+47 B
-1 B
WebGPU Nodes 511.21
140.1
511.26
140.1
+47 B
+0 B

@sunag sunag changed the title CSMShadowNode: Fix updateMatrices sequence ShadowNode: Fix updateMatrices sequence Dec 8, 2024
@sunag sunag marked this pull request as ready for review December 8, 2024 05:37
@sunag sunag merged commit c43288e into mrdoob:dev Dec 8, 2024
12 checks passed
@sunag sunag deleted the dev-fix-matrixupdate branch December 8, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSM Shadows broken
1 participant