Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Use correct elementType with WorkgroupInfoNode #30222

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

Related issue: #29192

Description

const localStorage = workgroupArray('uvec2', 64 * 2)

// before: (error)
localStorage.element(0) <-- WGSL will assign uint type

// after:
localStorage.element(0) <-- WGSL now assign correctly uvec2

This contribution is funded by Utsubo

@RenaudRohlinger RenaudRohlinger added this to the r172 milestone Dec 28, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.44
79.06
339.44
79.06
+0 B
+0 B
WebGPU 489.24
135.78
489.3
135.8
+60 B
+15 B
WebGPU Nodes 488.71
135.66
488.77
135.68
+60 B
+18 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 558.8
151.3
558.8
151.3
+0 B
+0 B
WebGPU Nodes 514.87
141.07
514.87
141.07
+0 B
+0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants