Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Derives language labels using Intl.DisplayNames #30237

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Dec 30, 2024

Related issue: #30196

This PR derives language labels for Settings>Language via Intl.DisplayNames,

and so it now supports fa locale

Test: https://raw.githack.com/ycw/three.js/editor-lang-displaynames/editor/index.html

@mrdoob mrdoob added this to the r172 milestone Dec 30, 2024
@mrdoob mrdoob merged commit b641098 into mrdoob:dev Dec 30, 2024
11 checks passed
@ycw ycw deleted the editor-lang-displaynames branch December 30, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants