WebGLBackground: Reset meshes in dispose()
.
#30257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #30230.
Description
When
renderer.dispose()
is called, the background'sdispose()
method is called as well sincer171
. If a renderer is used afterrenderer.dispose()
which is true for the editor, the background wasn't functional anymore. To force a call ofWebGLObjects.update()
,WebGLBackground.dispose()
simplify removes the references to its internal meshes which is also the more correct implementation.It is open for debate if using a renderer after
dispose()
is valid but this PR restores the behavior beforer171
.